search

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
19 stars 10 forks source link

The HELM for structures with groups is calculated differently if it is collapsed or expanded #130

Closed ClairePA closed 6 years ago

ClairePA commented 6 years ago

See below for an example. The collapsed HELM is the correct one.

image

image

scilligence commented 6 years ago

The problem itself is fixed, but there some other related issues are not completely fixed.

scilligence commented 6 years ago

Fixed 2017-11-06 update

ClairePA commented 6 years ago

HELM still changes when the group is collapsed.

scilligence commented 6 years ago

The two HELM notations are equal now:

Expanded: BLOB1{}|RNA1{R(U)P.R(G)P.R(G)}|RNA2{R(A)P.R(C)P.R(T)P}$RNA2,RNA1,9:R2-1:R1|RNA2,BLOB1,R:-:*$$$V2.0

Collapsed: BLOB1{}|RNA1{R(A)P.R(C)P.R(T)P}|RNA2{R(U)P.R(G)P.R(G)}$RNA1,RNA2,9:R2-1:R1|RNA1,BLOB1,R:-:*$$$V2.0

ClairePA commented 6 years ago

This particular example works now, but in the example below the naming of the simple polymers changes when collapsing the group. image

image

I think this may be OK, but will check with the team at tomorrow's meeting.

ClairePA commented 6 years ago

Agreed OK.