search

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
20 stars 10 forks source link

No validation on monomer position entries #133

Closed ClairePA closed 6 years ago

ClairePA commented 7 years ago

It is possible to add a number for the connection point to a monomer number that does not exist. See below;

image The toolkit picks up this kind of error. image

ClairePA commented 6 years ago

Validation can be done via a manual button on the canvas. The button should be the standard background colour to start, change to red if it fails validation, green if it passes.

scilligence commented 6 years ago

fixed in 2017-12-02 update. But the valication web service should specified as below:

               app = new scil.helm.App("div1", {
                    ...., validateurl: "Service.aspx?cmd=helm.validate",
               });
ClairePA commented 6 years ago

I can't see a button and have checked that I have the correct version.

scilligence commented 6 years ago

Sorry. It is in HELM tab

ClairePA commented 6 years ago

Ah, I have found it now thanks.

However, you still need to call the current functionality using whatever the toolkit currently has implemented or change the back end to fit your call.

The project does not have any further resource to help out with backend development work.

scilligence commented 6 years ago

So there are two service APIs should be exposed by the new Monomer Web Service: (1) convert SMILES into molfile (for bug #142); (2) validate a HELM

scilligence commented 6 years ago

Validate web service is implemented on the test page: http://54.91.164.146/HELM2MonomerService/hwe/examples/App.htm

ClairePA commented 6 years ago

Confirmed that the validation is present.