PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
20 stars 10 forks source link

Ratio information does not appear in the HELM string #139

Closed ClairePA closed 6 years ago

ClairePA commented 6 years ago

If I draw the following:

image

The ratio of 2:3 does not appear in the HELM string.

scilligence commented 6 years ago

Fixed in 2017-11-13 update

ClairePA commented 6 years ago

The HELM has changed, but it does not include the ratio numbers.

image

scilligence commented 6 years ago

I don't think there should be a bond connecting the two if there is a ratio.

ClairePA commented 6 years ago

The ratio information is better recorded against the bond since it is possible to have multiple components connected and the approach above does not work well with more than two fragments.

The UI should enforce the rule that ratios cannot be added to the group if the groups are connected by a bond.

scilligence commented 6 years ago

2017-12-09 update: ratio will be removed if the group is connected by a bond

ClairePA commented 6 years ago

Ratio information is removed if you change the ratio after drawing the bond, but drawing the bond does not remove existing ratio information.

image

Ironically the ratio information now does appear in the HELM string, so the original issue is fixed. Perhaps we should discuss tomorrow?

scilligence commented 6 years ago

decision from today's meeting:

  1. When drawing a bond connecting the two group, their ratio should be cleared.
  2. A warning message to be displayed: ratio will be removed ....
  3. Ratio number should be displayed as "ratio: 3"
scilligence commented 6 years ago

Fixed in 2017-12-13 update

ClairePA commented 6 years ago

Looks great and the warning message and change of text are good. Just one thing, only one of the ratios is cleared. image

scilligence commented 6 years ago

Sorry. there is typo. Fixed in 2017-12-14 update.

ClairePA commented 6 years ago

Confirmed fixed.