PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
20 stars 10 forks source link

No structure preview with inline SMILES #142

Closed MarkusWeisser closed 6 years ago

MarkusWeisser commented 6 years ago

Using inline smiles shows a symbol #1 on the canvas. No structure is displayed on mouse over.

scilligence commented 6 years ago

HELM Editor itself cannot parse SMILES, so it has to use web service to call server side to convert SMILES into molfile. The lookupurl parameter is used for this purpose

scilligence commented 6 years ago
            var args = {
                // ...
                cleanupurl: "??????" // web service to clean up structures
            };

            org.helm.webeditor.Adapter.startApp("div1", args);
ClairePA commented 6 years ago

This is not quattro's responsibility to fix. If the editor needs this function then Scilligence needs to write it. I do not mind whether it is a front or backend function but it is Scilligence's responsibility in either case.

scilligence commented 6 years ago

HELM web editor won't be able to parse SMILES - it is huge amount work to re-implement this using javascript.

The editor is ready to call a web service to convert SMILES into molfile. We can demo this using our web service.

ClairePA commented 6 years ago

OK, thanks. I look forward to seeing your new webservice in action. I assume you will combine the changes with the HELM webservice?

It is good to get this sorted out since the structure view is also affected.

image

scilligence commented 6 years ago

Need the backend web service to convert smiles into molfile

scilligence commented 6 years ago

Using new WAR file, and it is working now.

ClairePA commented 6 years ago

The tool tip looks good now. image

However when I select the two monomer molecule to display in the structure view, I get an error.

image

scilligence commented 6 years ago

Fixed now

ClairePA commented 6 years ago

It does not crash now, and does display the structures, but the monomers are not connected together.

image

scilligence commented 6 years ago

I cannot reproduce it. Could you upload the HELM notation you are using?

ClairePA commented 6 years ago

PEPTIDE1{[C@HCc1ccc(cc1)F |$;;;_R2;;;;;;;;$|].[Hse]}$$$$V2.0

scilligence commented 6 years ago

This is ChemAxon smiles, and I don't think CDK can read it.

ClairePA commented 6 years ago

Something is reading it since the structure is displayed. It looks more like there is an issue with the connection points not being understood.

scilligence commented 6 years ago

Fixed in 2018-01-08 update. It converts the ChemAxon SMILES into CDK acceptable smiles.

ClairePA commented 6 years ago

Now I get the following error using the HELM above:

image

scilligence commented 6 years ago

Remember to copy the HELM string in editing mode:

PEPTIDE1{[[C@H](C(=O)*)Cc1ccc(cc1)F |$;;;_R2;;;;;;;;$|].[Hse]}$$$$V2.0

ClairePA commented 6 years ago

OK, looks fine.