PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
18 stars 10 forks source link

Can't create a new monomer #156

Closed ClairePA closed 6 years ago

ClairePA commented 6 years ago

If I create a new monomer using the monomer manager and click OK, I get a 404 error.

image

scilligence commented 6 years ago

It looks like the problem is in Monomer Web Service side. Here is message I got now, using PUT:

image

MarkusWeisser commented 6 years ago

The latest release of the monomer service has an updated Swagger page with the body parameter. Could you please try this. The following JSON works on my side:

{ "symbol": "Test1", "name": "Test2", "molfile": "xxx", "author": "UnknownAuthor", "id": 0, "rgroups": [{ "id": 0, "alternateId": null, "label": "R3", "capGroupName": "X", "capGroupSMILES": null }], "smiles": "cccccc", "monomerType": "Undefinded", "naturalAnalog": "X", "polymerType": "CHEM", "createDate": "Thu Jan 25 11:16:17 CET 2018" }

Please have in mind that SMILES and MOLFILE have to be unique!

ClairePA commented 6 years ago

I have tried saving a new monomer since the service was updated and I do not get an error when I create a monomer, but the monomer is not listed once I have saved it.

I get no feedback when I click the save button, which makes me think that clicking "save" is not doing anything.

scilligence commented 6 years ago

Which URL do you use? You might want to update hwe folder by downloading the new version from here: https://github.com/PistoiaHELM/HELMWebEditor/releases

Here is the test site: http://54.91.164.146/HELM2MonomerService/hwe/

ClairePA commented 6 years ago

I use the webeditor test site you set up at http://54.91.164.146/HELM2MonomerService/hwe/examples/MonomerLibApp.htm.

scilligence commented 6 years ago

Markus, I got null in Response if trying to create a new CHEM. Is it possible to return any error message if failed:

image

image

ClairePA commented 6 years ago

Tony - can you check the format of the JSON as it includes R groups listed separately as well as in the array? Only the array should be used. Quattro are working on additional error messages.

scilligence commented 6 years ago

I upgrade HELM2MonomerService.war to release 7. It looks like it works now.

ClairePA commented 6 years ago

I still can't create a new monomer using the test version. Has this been updated? I get no error message, but the new monomer is not there.

ClairePA commented 6 years ago

Monomer is now created. Close.