search

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
18 stars 10 forks source link

Returned error messages are not displayed in the editor #166

Closed ClairePA closed 6 years ago

ClairePA commented 6 years ago

If I create an existing monomer with a new symbol an error is generated by the monomerservice. However this error is not displayed to the user.

scilligence commented 6 years ago

Could you give one specific example? It does pick up the error message received from JSON, and display it.

ClairePA commented 6 years ago

OK, my explanation was not clear. Most of the errors are handled and the user is warned when information is missing on save. There are two examples where this is not done.

Changing a monomer's symbol

Steps: Edit a monomer and change the symbol.
Save the monomer It is not updated on save and the user is not warned.

Creating a new monomer with an existing symbol

Steps Create a new monomer and give it the same symbol as an existing one. Save the monomer. On saving the existing one is overwritten so it does not create a duplicate. (creating a duplicate would be bad). It would be better if it warned you first and refused to save at all.

scilligence commented 6 years ago

Markus,

Could you check this case on the Web Service side?

Here is the response of this RESTful call: image

And here is the Request data (Only Symbol is changed in this case) image

ClairePA commented 6 years ago

Rechecked and this issue is still there.

ClairePA commented 6 years ago

Moved the examples to issues #215 and #216 to track more accurately.