Export to SMILES in Monomer manager does not do anything - Githubissues

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.

MIT License

18 stars 10 forks source link

Export to SMILES in Monomer manager does not do anything #176

Closed ypotier closed 6 years ago

ypotier commented 6 years ago

The Export option in the monomer manager allows to choose between mol and SMILES. While mol is working, the SMILES choice will remain blank.

Of course, the SMILES is available in the SMILES field so it's not a blocker but we could display the SMILES since we already have it, or remove that option.

scilligence commented 6 years ago

SMILES is not supported. The option is removed in 2018-05-01 update

ClairePA commented 6 years ago

Confirmed OK to remove SMILES.

Drop down list should default to molfile as there are no alternatives.

scilligence commented 6 years ago

Fixed 2018-05-06 update

ClairePA commented 6 years ago

It looks like the whole export option has been removed. I think we wanted the export to remain, but default to molfile since this is the only format available.

ypotier commented 6 years ago

I can still see the export, and MOL export is selected by default with the content visible.

ClairePA commented 6 years ago

Sorry - I'm being dense and I have found it now. The import is fine, but the export doesn't default to mol and mol is the only option. Could we get this fixed?

ClairePA commented 6 years ago

Arrgghh having a really bad day.

Export is fine.
Import needs to default to mol.

Thanks to Yohann for pointing this out.

scilligence commented 6 years ago

Fixed in 2018-05-13 update

ClairePA commented 6 years ago

Confirmed fixed. Close.