search

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
17 stars 10 forks source link

New rule added to ruleset is not accessible in canvas #211

Closed ypotier closed 5 years ago

ypotier commented 5 years ago

Hi,

I added a new rule in http://54.83.135.171/HELM2MonomerService/hwe/examples/RuleSetApp.htm (replace P by sP). It is saved correctly, but I cannot see this new ruleset from the canvas (app page) and rule tab.

ClairePA commented 5 years ago

This sounds like a similar problem to the monomer refresh issue. Can we put in a fix similar to the monomer fix where the webservices update the set of rules on creation of a new rule. This is causing Novartis a problem with their internal implementation.

scilligence commented 5 years ago

Fixed now, in javascript side

ClairePA commented 5 years ago

Retested and looks fixed to me. Yohann - could you check and close if you are happy?

ypotier commented 5 years ago

It looks good: the rule is now visible from the canvas as expected. However, it introduced a new bug when create a rule with quote. Where the single quote symbol is added and create an error when trying to apply the rule. I am creating a new ticket for it so this one can be closed.