search

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
17 stars 10 forks source link

Cannot edit rules #222

Closed ypotier closed 5 years ago

ypotier commented 5 years ago

When trying to edit an existing rule, the following error message is displayed: Unable to load /HELM2MonomerService/rest/rule status: 409

scilligence commented 5 years ago

  1. This error is fixed in 2018-10-08

  2. The HELM Monomer Webservice doesn't have Update method: http://54.83.135.171/HELM2MonomerService/

ypotier commented 5 years ago

If there is no no update method, the 'edit/pen' icon is confusing. I assume we cannot use the 'PUT' method to update existing rule?

AnneMund commented 5 years ago

The put method can be used to both create and update rules - you can try it out yourself via swagger:

Place a get request for a rule: grafik

Copy the json into the PUT method, changing whatever you wish (except for the ID): grafik

View the result via get again: grafik

ClairePA commented 5 years ago

Tony - can you try this out and let us know how it goes please?

scilligence commented 5 years ago

Fixed in 2018-10-15 update

ClairePA commented 5 years ago

OK, now there are two different modification situations.

1) if you change the rule name, a new rule is created by the old rule stays there. The user is not warned that this is the case and it will be confusing. The old rule name should be deleted.

2) if you change the description I still get the 409 error.

image

ClairePA commented 5 years ago

Retested. Confirmed fixed.

ypotier commented 5 years ago

@ClairePA , I was able to change the description without error on the current version