search

PistoiaHELM / HELMWebEditor

Web browser based editor for drawing HELM macromolecules.
MIT License
19 stars 10 forks source link

Alphabetical ordering of monomers is not working #98

Closed ClairePA closed 7 years ago

ClairePA commented 7 years ago

The previous version of the monomer manager ordered the monomers by Symbol. The latest update seems to have lost this.

image

Filtering by symbol or name is not working either.

scilligence commented 7 years ago

Fixed

ClairePA commented 7 years ago

Ordering is fixed, but the filtering by symbol/name is not fixed.

scilligence commented 7 years ago

Fixed

ClairePA commented 7 years ago

The filtering is now an exact match, whereas I believe we asked for 'starts with'.

scilligence commented 7 years ago

We changed it into "contains"

ClairePA commented 7 years ago

Contains means that you get a very wide number of results when looking for a simple monomer. For example searching for R gives Serine as a result which is not intuitive. I would prefer the symbol and name search to be separated, if this is not possible then the search must be a 'starts with' However combining name and symbol searches will always be confusing.

scilligence commented 7 years ago

It uses contains for Symbol, and starts with for Name. For example, when user types A, it can match mA

ClairePA commented 7 years ago

OK, that seems reasonable. I still think it would be better to separate the symbol and name searching to make it clearer, but we will wait and see if anyone requests this before actually doing anything.