search

PistonDevelopers / VisualRust

Visual Studio extension for Rust
MIT License
701 stars 73 forks source link

Treat all files as UTF8 and save it without BOM #260

Closed Vbif closed 7 years ago

Vbif commented 7 years ago

https://github.com/PistonDevelopers/VisualRust/issues/259

Vbif commented 7 years ago

I have tested it on templates with BOM. After edit and save procedure, BOM header war removed from file.

Boddlnagg commented 7 years ago

I'd still be in favor of never having a BOM in the templates to begin with. Imagine someone creates an empty project and checks it into source control. Then something is changed and the file is saved, the BOM is removed, and suddenly you have a mysterious change in the first line of the file.

What would be the advantage of keeping the BOM? Does anyone else have an opinion about this?

andersforsgren commented 7 years ago

Agree - the save encoding and the templates should be consistent to avoid spurious diffs.

Vbif commented 7 years ago

@Boddlnagg My English skills are pretty bad, so you might misunderstand me. I am don't voting for BOM and I will push changes for templates today. Just clarify how I tested this changes.

Boddlnagg commented 7 years ago

@Vbif Oh, sorry that I misunderstood you. All right then 👍