Build system doesn't detect modified files

[MihaMarkic]

"Build Solution" won't detect modified files and won't compile anything if there is an earlier compilation available. "Rebuild Solution" will work.

Steps to reproduce:

Create a new project, compile it, change output from Hello World! to something else, do a Build Solution and run it.

Expected behavior:

New text should be visible.

Actual behavior:

"Hello world!" is displayed.

System

VS2015, rustc 1.14.0, VR 0.1.2

[Vort]

Project build - the main feature of the plugin - is broken and no one cares about it? That's strange.

[Vbif]

Try last release https://ci.appveyor.com/project/vosen/visualrust/build/145/artifacts . It use cargo to build a project

[Vort]

@Vbif, MSBuild.exe crashes with System.NullReferenceException while trying to build default "Hello, world!" project. I can provide additional information if needed.

[MaulingMonkey]

I fixed one MSBuild NullReferenceException crash which I suspect was @Vort 's issue in https://github.com/PistonDevelopers/VisualRust/pull/286 . Unofficial test build @ https://ci.appveyor.com/project/MaulingMonkey/visualrust/build/1/artifacts , no idea if it's appropriately codesigned or not.

Changes to the project are showing up in builds (e.g. @MihaMarkic 's original bug is fixed?) for me as of: VS2015 u3 rustc 1.18.0 (03fc9d622 2017-06-06) cargo 0.19.0 (28d1d60d4 2017-05-16) Visual Rust "0.2" ( https://github.com/MaulingMonkey/VisualRust/tree/e070ed2e1104a049d5a6119761d760b1b7d8a879 )

[Vort]

@MaulingMonkey, I've tested that build with VS 2015 and Rust 1.19.0. Looks like problem is gone. But this changes should be released to become available for users, right?

[MaulingMonkey]

I hope so, but so far nobody's reviewed my pull request.

[Boddlnagg]

The maintainer of this project is @vosen, and he's also the only one who can release new versions. Unfortunately I do not have time right now to review myself, and also I don't know enough about vosen's plans for the future direction of some features of VisualRust, making it hard for me to review any non-trivial PRs.

But anyway, thank you very much for your PR, @MaulingMonkey! 👍

[MaulingMonkey]

I did notice @vosen shows some activity every month or two, so I'm hopeful my changes might at least get reviewed in the next cycle. And I'm assuming this is largely volunteer work or side projects, so it's completely understandable to be pressed for time, and to have higher priorities elsewhere :wink:. Worst case scenario I can start more actively maintaining my own fork as a longer term thing - I just want to avoid it becoming another permanent fork if it can at all be helped.

Thanks for the kind words, and your work which I'm building on, @Boddlnagg :+1: