Fix Msbuild, fix project/item templates, improve intellisense.

PistonDevelopers / VisualRust

Visual Studio extension for Rust

MIT License

701 stars 73 forks source link

Fix Msbuild, fix project/item templates, improve intellisense. #286

Open MaulingMonkey opened 7 years ago

MaulingMonkey commented 7 years ago

Unofficial Preview Builds

https://ci.appveyor.com/project/MaulingMonkey/visualrust/build/8

Overview of Changes

Fixed project/item templates (bad paths, missing from release .vsix)
Msbuild fixes (null derefs from non-messages in cargo 0.19, macro spans with invalid paths)
Intellisense improvements (using the optional 'substitute_file' for better results, refined when intellisense is triggered, added display of doc comments)
Misc. cleanup (racer and lexer refactoring, CompositionException fix, build vsix in debug)

Notes

It might be more appropriate to check if RustcMessageJson is null at the call site instead of inside the function
It might be worth logging features as reported by cargo somewhere
I've only tested the 2015 builds/paths
I'm a single-line conditional using heathen

Let me know if you'd prefer I do anything differently

Boddlnagg commented 6 years ago

Maybe we should get some attention from the Rust team to the situation here (that VisualRust is essentially unmaintained, because @vosen does not respond ...).

MaulingMonkey commented 6 years ago

Mmm. Or people from the PistonDevelopers group? I don't know the hierarchy/dynamics here. Or I could try @vosen 's email?

It would be good to unblock contribution. I effectively stopped working on additional Visual Rust features because this pull request is already uncomfortably large. I want to avoid causing another dead fork (it looked like there was one adding AST parsing?) with duplicated or wasted effort.

Since this pull request, my free time has been curtailed by a job as well, although I'd be willing to try and help tackle maintainer duties if added to the repository. Although that doesn't get this code reviewed by someone else, which would still be nice to have - although maybe not at the expense of progress.

Boddlnagg commented 6 years ago

@MaulingMonkey I have added you as a collaborator to this repository. I will try to find some time to review your PR, if @vosen remains unresponsive ...

You could definitely try to reach him by email ...

MaulingMonkey commented 6 years ago

Finally pinged @vosen via email on Monday, no response so far though. I'm inclined to go ahead and just merge this next week sometime - I can always respond to feedback after the merge too.

MaulingMonkey commented 6 years ago

https://github.com/PistonDevelopers/VisualRust/issues/302 may block merging this - I tried to manually make a new build via appveyor and hit the quota error again.

Boddlnagg commented 6 years ago

Okay, from my side you can feel free to merge this whenever you know how to deal with #302 👍

Boddlnagg commented 6 years ago

You might also be interested in https://github.com/dgriffen/rls-vs2017