search

PistonDevelopers / VisualRust

Visual Studio extension for Rust
MIT License
701 stars 73 forks source link

Could not uninstall VSIX - looking for LICENSE.txt #301

Open clairernovotny opened 6 years ago

clairernovotny commented 6 years ago

Trying to uninstall the latest VSIX, the VSIX Installer crashed with an error about a missing file: C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\PREVIEW\ENTERPRISE\COMMON7\IDE\LICENSE.txt

If I add that file manually, it will uninstall. Seems like the VSIX has a relative path somewhere instead of an absolute one? Not sure why it'd be looking for a file in that directory otherwise.

Boddlnagg commented 6 years ago

Just to clarify: which "latest" VSIX do you refer to? The one released on the market place? Or the latest AppVeyor build?

clairernovotny commented 6 years ago

The latest AppVeyor build from this project (VS 2017).

clairernovotny commented 6 years ago

I'm betting this is the issue: https://github.com/PistonDevelopers/VisualRust/blob/master/src/VisualRust/source.extension.release.2017.vsixmanifest#L7

MaulingMonkey commented 6 years ago

There are some inconsistencies in the .vsixmanifest <License> paths:

source.extension.debug.vsixmanifest: LICENSE.txt source.extension.release.2015.vsixmanifest: ..\..\LICENSE.txt source.extension.release.2017.vsixmanifest: ..\..\LICENSE.txt

MaulingMonkey commented 6 years ago

Eyeballing the existing .vsix es, it looks like LICENSE.txt is the correct path. I'll roll a fix into my PR.