PixarAnimationStudios / OpenUSD-proposals

Share and collaborate on proposals for the advancement of USD
106 stars 27 forks source link

Text schema-level feedback #57

Open tcauchois opened 7 months ago

tcauchois commented 7 months ago

Hi all,

I've got some notes on the Autodesk text proposal. This issue is specifically focused on USD schema issues; I'm planning to file another issue about the hydra implementation. Hoping some text-knowledgeable folks can sanity check this but some things that jumped out at me:

Feedback on SimpleText:

Feedback on TextStyle:

Feedback on TextLayout:

Are TextStyle and TextLayout prims that SimpleText has a relationship to, or API schemas? It's unclear from the proposal. It seems likely to encounter a scene with a lot of text using the same styling, so making TextStyle a separate prim lets the scene define a global TextStyle and refer all of its SimpleText prims to that style, which seems appealing.

Feedback on MarkupText:

Feedback on ColumnStyle:

Feedback on ParagraphStyle:

Thanks! Tom

meshula commented 7 months ago

I'll take /one/ of them :)

if you've got a piece of paper, the paper defines the root coordinate system and metric

margins are /effectively/ the viewport on the paper, and the first layer of coordinate system under the root system

indent is a coordinate system under the margins coordinate system, or within another indent coordinate system (although I haven't mentally parsed whether indents nest in this proposal)

PierreWang commented 7 months ago

@tcauchois Thank you for your comment.

Sorry I haven't checked the comments after fontType. I will continue the discussion tomorrow.

PierreWang commented 7 months ago

@tcauchois Continue with the previous comments.

PierreWang commented 7 months ago