PlanetaryRobotics / IrisRoverPackage

Complete software package for the Iris Lunar Rover (CMU).
GNU General Public License v3.0
14 stars 2 forks source link

Possible bitmask clearing issue in i2c handler. #120

Open zCoCo opened 2 years ago

zCoCo commented 2 years ago

Check that g_statusRegister &= ~STATE_MACHINE_DISABLE;is the way the g_controlRegister & STATE_MACHINE_RUN bit should be cleared... Seems not since that's not how the others are cleared (and, you know, it's a different bit). Is this intended to trigger some secondary functionality instead of immediately clearing the bit? If so, that should be more evident.

https://github.com/PlanetaryRobotics/CubeRoverPackage/blob/c10bc8bf5c76444d3799a6e2bf16fc76672437b8/Apps/FlightSoftware/MotorControl/i2c.c#L261-L264