Missing Command Handlers in `MotorControl` - Githubissues

PlanetaryRobotics / IrisRoverPackage

Complete software package for the Iris Lunar Rover (CMU).

GNU General Public License v3.0

14 stars 2 forks source link

Missing Command Handlers in `MotorControl` #179

Open zCoCo opened 1 year ago

zCoCo commented 1 year ago

[ ] Some lower-priority commands are missing command handlers in the MotorControl FPrime component. These should either be implemented or deprecated and removed.
[ ] Also, some commands have TODO comments suggesting they're implemented improperly or do nothing. All of these should be tested before use.

Examples of unimplemented:

https://github.com/PlanetaryRobotics/CubeRoverPackage/blob/e4a77942b1e4a6396a554e00984baf8284dcc396/Apps/FlightSoftware/fprime/CubeRover/MotorControl/MotorControlComponent.cpp#L475-L490

https://github.com/PlanetaryRobotics/CubeRoverPackage/blob/e4a77942b1e4a6396a554e00984baf8284dcc396/Apps/FlightSoftware/fprime/CubeRover/MotorControl/MotorControlComponent.cpp#L492-L511

[... there are more in this file]

Examples of dubious implementation:

https://github.com/PlanetaryRobotics/CubeRoverPackage/blob/e4a77942b1e4a6396a554e00984baf8284dcc396/Apps/FlightSoftware/fprime/CubeRover/MotorControl/MotorControlComponent.cpp#L570-L601

https://github.com/PlanetaryRobotics/CubeRoverPackage/blob/e4a77942b1e4a6396a554e00984baf8284dcc396/Apps/FlightSoftware/fprime/CubeRover/MotorControl/MotorControlComponent.cpp#L319-L360

[... there are more in this file]