Style alert callouts - Githubissues

Polymer / polymer-project.org

Polymer Project site & blog.

15 stars 13 forks source link

Style alert callouts #12

Closed keanulee closed 5 years ago

arthurevans commented 5 years ago

Very cool. My one concern is that the yellow text on white background is very hard to read. At a contrast ratio of 2.66:1, it fails the accessibility test by a good margin.

https://webaim.org/resources/contrastchecker/?fcolor=EA8600&bcolor=FFFFFF

If we're going to add this to the other sites as well, I'd love a Tip style (lightbulb icon, maybe some color of green).

keanulee commented 5 years ago

cc @yuinchien

yuinchien commented 5 years ago

Let's update the warning text color to #E42B00, at 16px the contrast ratio will be 4.52 (AA compliant). Thanks!

chip

keanulee commented 5 years ago

Much better now, thanks!

arthurevans commented 5 years ago

Sold!