Closed yuinchien closed 5 years ago
frankiefu
commented
5 years ago The grid layout issue seems to be fixed now, Yay! And the new About, Latest news sections look beautiful!
I think main.css is supposed to be shared with other projects (e.g. lit-html, lit-element...). And CSS for that specific project should go in to the <style> in index.html. I will let @keanulee to review the code to make sure.
frankiefu
commented
5 years ago @yuinchien Saw a warning in the console about using unescaped '#' characters in a data URI:
I think this is from the arrow svg change from your previous PR: https://github.com/Polymer/polymer-project.org/pull/11/files#diff-d98a77b8f81515ceaa06d2543b9530cdR182
Basically it needs to change from fill="#FF4470" to fill="%23FF4470" in the date URI. Let's fix it in this PR.
arthurevans
commented
5 years ago Sorry for the delay. Agree with Frankie that the new stuff looks 👍 . But not sure where the css belongs, so will wait to hear from @keanulee on this one.
yuinchien
commented
5 years ago @arthurevans i tried to create typographic scale & layout design by working with the current content, but the blurbs don't seem to be very consistent in text length & punctuation
Individual landing page blurb doesn't have punctuation
Polymer project landing page blurb has punctuation & is a bit shorter, is it possible to edit the blurb and make it a bit longer so visually it's more balanced?
The 2nd column has little description compared to the other two, can we add a bit more description for the 2nd column?
keanulee
commented
5 years ago @arthurevans will leave it for you to merge. Maybe address Yuin's comments about the blurbs in another PR.
arthurevans
commented
5 years ago Hi Yuin. The blurb on the project site is punctuated because it's two sentences—fragments, actually—the others didn't need any punctuation.
Will see what I can do about these two bits of text, but I'll merge this PR first.
arthurevans
commented
5 years ago These updates are deployed.
…ction layout.