Popcorn-Limited / vaultcraft

https://vaultcraft.vercel.app
4 stars 6 forks source link

Vault dust contributing to high costs for oVCX claims #222

Closed J-n-a-k closed 3 months ago

J-n-a-k commented 3 months ago

Claiming oVCX has resulted in crazy high tx costs for me recently. Even though I'm only in two boost vaults right now, costs are way more than 2x what they were when I was in a single vault.

I have a hypothesis as to why. I had deposits in other boost vaults that I've since withdrawn, but after max withdrawal transactions there was dust left in those vaults. That dust is now still earning minuscule amounts of oVCX. So now every time I claim, the dApp also claims that dust oVCX from the dust in those vaults.

I don't know there's a way to prevent dust from being left in vaults after max withdrawals, but if not maybe there's a way to only allow oVCX to be claimed from a vault if it's over a certain amount. Otherwise claim costs will get higher and higher for the most active and long-term users of the dApp.

Mischa0x commented 3 months ago

Thanks for sharing. Will share get back to you ASAP!

RedVeil commented 3 months ago

We now only try to claim if a gauge has more than 1000 oVCX in rewards accrued. This should eliminate this issue