search

Porthmeus / MeMoMe

Metabolic Model Merging - a semiautomated way to merge genome scale metabolic models
Apache License 2.0
0 stars 0 forks source link

Thomas/feature/81 #100

Open Unaimend opened 3 months ago

Unaimend commented 3 months ago

Fixes #86 and #81.

We just iterate over all databases until no change in annotated inchis/dbs/names is detected

Porthmeus commented 3 months ago

please remove the fix for #86 in this PR, as ignoring the problem is not fixing it.

Unaimend commented 3 months ago

please remove the fix for #86 in this PR, as ignoring the problem is not fixing i

please remove the fix for #86 in this PR, as ignoring the problem is not fixing it.

This PR is not executable without this "fix"

Porthmeus commented 3 months ago

please remove the fix for #86 in this PR, as ignoring the problem is not fixing i

please remove the fix for #86 in this PR, as ignoring the problem is not fixing it.

This PR is not executable without this "fix"

Does it spit a warning at least? We should keep the issue open in any case.

Unaimend commented 3 months ago

please remove the fix for #86 in this PR, as ignoring the problem is not fixing i

please remove the fix for #86 in this PR, as ignoring the problem is not fixing it.

This PR is not executable without this "fix"

Does it spit a warning at least? We should keep the issue open in any case.

As discussed, it does

Porthmeus commented 2 months ago

need fixing of #132 otherwise this will fail

Unaimend commented 2 months ago

Test case thats failing image

image Output of the matching.

You can see that keep1ToMany is false but the output contains one to many matches. I think they have been matched on inchi so the matchInchi function does not properly respect the parameter