search

Porthmeus / MeMoMe

Metabolic Model Merging - a semiautomated way to merge genome scale metabolic models
Apache License 2.0
0 stars 0 forks source link

keep1ToMany not respected #140

Closed Unaimend closed 4 months ago

Unaimend commented 4 months ago 
          Test case thats failing

image

image Output of the matching.

You can see that keep1ToMany is false but the output contains one to many matches. I think they have been matched on inchi so the matchInchi function does not properly respect the parameter

Originally posted by @Unaimend in https://github.com/Porthmeus/MeMoMe/issues/100#issuecomment-2098331286

Unaimend commented 4 months ago

image But there is a test case for that

Unaimend commented 4 months ago

The above mentioned test case does indeed miss this case

Porthmeus commented 4 months ago

tried and can't replicate the problem - please check again:

from pathlib import Path
from src.MeMoMetabolite import MeMoMetabolite
this_directory = Path("tests/")
dat = this_directory.joinpath("dat")
mod_path = dat.joinpath("e_coli_core.xml")
mod = MeMoModel.fromPath(mod_path)
mod.annotate()
res = mod.match(mod, keep1ToMany= False)

image