Closed Porthmeus closed 2 months ago
Question: Do we want to also flag reactions that only differ in 1 or 2 protons? Which could indicate different protonation states between the same metabolite entries.
I would not delete /replace them outright unless there is a 100% certainty that the two mets are identical.
Generally: the metabolite duplication detection should be designed as a preprocessing step which can produce SBML files so that the user can have a clean model.
Previous comments on other channels: Bram brought up a row of problems with the preprocessing:
cobramodel
slot of the MeMoModel object - this needs to be implemented for loading the model from Path and SBML
Some models have the same metabolite under different IDs in the model. This potentially causes one-to-many relationships when comparing two models, thus we would need to unify the metabolites in terms of the identifier. Thus a small function for comparison of the metabolites within one model would be needed to identify these metabolites.