PowerShell / PSResourceGet

PSResourceGet is the package manager for PowerShell
https://www.powershellgallery.com/packages/Microsoft.PowerShell.PSResourceGet
MIT License
484 stars 92 forks source link

ACR Integration: Bug fix for publishing a module that is not all lowercase to ACR repo #1502

Closed alerickson closed 8 months ago

alerickson commented 8 months ago

PR Summary

This PR addresses a small bug when publishing to ACR registries. ACR only allows all lowercase names. This PR takes all module names and ensures that it's lowercase when publishing to ACR. It does not modify the files or .nupkg, just the name that gets sent in the HTTP calls to ACR.

PR Context

Previously, when attempting to publish 'TestModule.psd1' a 404 error would be returned. The exact same file named 'testmodule.psd1' would successfully publish. This is because the Publish-PSResource implementation gets the module name from the file _pkgName = System.IO.Path.GetFileNameWithoutExtension(pathToFileToPublish). However, ACR does not care about the casing of the file or the .nupkg, just the metadata it receives.

PR Checklist