This PR addresses a small bug when publishing to ACR registries. ACR only allows all lowercase names. This PR takes all module names and ensures that it's lowercase when publishing to ACR. It does not modify the files or .nupkg, just the name that gets sent in the HTTP calls to ACR.
PR Context
Previously, when attempting to publish 'TestModule.psd1' a 404 error would be returned. The exact same file named 'testmodule.psd1' would successfully publish. This is because the Publish-PSResource implementation gets the module name from the file _pkgName = System.IO.Path.GetFileNameWithoutExtension(pathToFileToPublish). However, ACR does not care about the casing of the file or the .nupkg, just the metadata it receives.
If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
PR Summary
This PR addresses a small bug when publishing to ACR registries. ACR only allows all lowercase names. This PR takes all module names and ensures that it's lowercase when publishing to ACR. It does not modify the files or .nupkg, just the name that gets sent in the HTTP calls to ACR.
PR Context
Previously, when attempting to publish 'TestModule.psd1' a 404 error would be returned. The exact same file named 'testmodule.psd1' would successfully publish. This is because the Publish-PSResource implementation gets the module name from the file
_pkgName = System.IO.Path.GetFileNameWithoutExtension(pathToFileToPublish)
. However, ACR does not care about the casing of the file or the .nupkg, just the metadata it receives.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.