PowerShell / PSResourceGet

PSResourceGet is the package manager for PowerShell
https://www.powershellgallery.com/packages/Microsoft.PowerShell.PSResourceGet
MIT License
487 stars 93 forks source link

enable isJFrogRepo flag for domains containing `artifactory` #1532

Closed sean-r-williams closed 8 months ago

sean-r-williams commented 8 months ago

PR Summary

This PR updates the conditions where V2ServerAPICalls._isJFrogRepo is enabled to include repos where artifactory is in the URL

This PR should resolve #1530.

PR Context

JFrog hosted Artifactory instances all fall under the jfrog.io domain, but selfhosted Artifactory instances are not necessarily beholden to this requirement. Moreover, the Artifactory product-line (as I understand it) predates JFrog's rearchitecture into the "JFrog Platform" (including component services like Artifactory), so older installations may not make the distinction between "JFrog" and "Artifactory"

This PR would entail a behavioral change for any selfhosted Artifactory instances that fall under this scenario. However, any behavioral changes gated behind that flag were most-likely intended for Artifactory, so this is probably a good thing.

PR Checklist