PowerShell / PSResourceGet

PSResourceGet is the package manager for PowerShell
https://www.powershellgallery.com/packages/Microsoft.PowerShell.PSResourceGet
MIT License
486 stars 92 forks source link

Pat token fix #1599

Closed gerryleys closed 5 months ago

gerryleys commented 6 months ago

PR Summary

PR Context

PR Checklist

gerryleys commented 6 months ago

@gerryleys please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="KU Leuven"]

gerryleys commented 6 months ago

@microsoft-github-policy-service agree

gerryleys commented 6 months ago

PS SecretStore 'SecureString' object is governed as a (PAT) token, instead of parsed to a PSCredential Object and treathed as a 'username/password' auth. (Issue #1593) This 'token' will translate into a HttpClient 'Basic Authorization' to access an Azure Devops onprem private artifcats feed.

alerickson commented 6 months ago

@gerryleys thanks for opening up this PR. There seems to be some build issues, can't tell what's going on from the CI validation, but please run .\build.ps1 -Clean -Build -BuildConfiguration Debug on the root directory to view and fix errors.

gerryleys commented 6 months ago

@alerickson Any update on the fix? Is there something I can do (or forgot to do) for this PR? Thanks in advance.

alerickson commented 5 months ago

/azp run PowerShell.PSResourceGet

azure-pipelines[bot] commented 5 months ago
Azure Pipelines successfully started running 1 pipeline(s).