issues
search
PowerShell
/
PSResourceGet
PSResourceGet is the package manager for PowerShell
https://www.powershellgallery.com/packages/Microsoft.PowerShell.PSResourceGet
MIT License
479
stars
90
forks
source link
ACR: clean up codebase, add error handling and comments
#1602
Closed
anamnavi
closed
4 months ago
anamnavi
commented
4 months ago
This PR:
creates a static instance of the empty FindResults instance, so that it can be returned in all error cases for the overriden methods
add error handling, for async methods these will throw, for non-async methods these out an ErrorRecord instance
categorize methods into more defined regions, for easier reading
add summary comments before each method
PR Summary
PR Context
PR Checklist
[x]
PR has a meaningful title
Use the present tense and imperative mood when describing your changes
[x]
Summarized changes
[x]
Make sure all
.h
,
.cpp
,
.cs
,
.ps1
and
.psm1
files have the correct copyright header
[ ] This PR is ready to merge and is not
Work in Progress
.
If the PR is work in progress, please add the prefix
WIP:
or
[ WIP ]
to the beginning of the title (the
WIP
bot will keep its status check at
Pending
while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
[ ] None
OR
[ ] [Documentation needed]()
[ ] Issue filed:
User-facing changes
[ ] Not Applicable
OR
[ ] [Documentation needed]()
[ ] Issue filed:
Testing - New and feature
[ ] N/A or can only be tested interactively
OR
[ ]
Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary.
This PR:
PR Summary
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.