issues
search
PowerShell
/
PSResourceGet
PSResourceGet is the package manager for PowerShell
https://www.powershellgallery.com/packages/Microsoft.PowerShell.PSResourceGet
MIT License
494
stars
93
forks
source link
Fix 1541 "`-WhatIf` results in extra, unwanted output and a spurious error"
#1711
Closed
o-l-a-v
closed
1 month ago
o-l-a-v
commented
2 months ago
PR Summary
Fixed check for whether -WhatIf was passed
Don't throw if -WhatIf was passed if no packages to install
Make sure tests exists and works
Fix and surpress PSScriptAnalyzer warnings in tests I touced
PR Context
1541
PR Checklist
[x]
PR has a meaningful title
Use the present tense and imperative mood when describing your changes
[x]
Summarized changes
[x]
Make sure all
.h
,
.cpp
,
.cs
,
.ps1
and
.psm1
files have the correct copyright header
[x] This PR is ready to merge and is not
Work in Progress
.
If the PR is work in progress, please add the prefix
WIP:
or
[ WIP ]
to the beginning of the title (the
WIP
bot will keep its status check at
Pending
while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
[x] None
OR
[ ] [Documentation needed]()
[ ] Issue filed:
User-facing changes
[x] Not Applicable
OR
[ ] [Documentation needed]()
[ ] Issue filed:
Testing - New and feature
[ ] N/A or can only be tested interactively
OR
[x]
Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary.
PR Summary
PR Context
1541
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.