For the FindNameHelper() the regex was:
test_local_mod.\d+.\d+.\d+(?:[a-zA-Z0-9-.]+|.\d)?.nupkg
The first '.' matches any character whereas our intention with the regex is to match the literal '.' so I added a backslash before the '.' to escape it. If the package being searched for is test_local_mod it was matching test_local_mod.1.0.0.nupkg and also test_local_mod2.1.0.0.nupkg where the '' character was getting matched by '.' in regex
and 2.1.0.0 was getting considered as the version.
The main issue Amber had found was that for FindVersionHelper() the path for the .nupkg was being constructed and we use lowercasing so on Linux that path will not be correct. Instead, once we find a matching package (by name and version) we should use the path given from the file system that has the correct casing.
If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
For the FindNameHelper() the regex was: test_local_mod.\d+.\d+.\d+(?:[a-zA-Z0-9-.]+|.\d)?.nupkg
The first '.' matches any character whereas our intention with the regex is to match the literal '.' so I added a backslash before the '.' to escape it. If the package being searched for is
test_local_mod
it was matching test_local_mod.1.0.0.nupkg and also test_local_mod2.1.0.0.nupkg where the '' character was getting matched by '.' in regex and2.1.0.0
was getting considered as the version.The main issue Amber had found was that for FindVersionHelper() the path for the .nupkg was being constructed and we use lowercasing so on Linux that path will not be correct. Instead, once we find a matching package (by name and version) we should use the
path
given from the file system that has the correct casing.PR Summary
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.