PowerShell / PSResourceGet

PSResourceGet is the package manager for PowerShell
https://www.powershellgallery.com/packages/Microsoft.PowerShell.PSResourceGet
MIT License
489 stars 94 forks source link

Please fix PowerShellGetv2 Bug for Powershell Core modules update #617

Open echalone opened 2 years ago

echalone commented 2 years ago

Prerequisites

Steps to reproduce

Since this new PowerShellGet module is still not ready and doesn't look like it will be anytime soon (it's more than a year now since I posted the original bug in the old module) I really think the bug in the old module which will reinstall all modules in the user scope instead of the global scope if you update a module should be fixed with my Pull Request there. Could you maybe make this happen even though its not under development any more? You still add other stuff to it apparently, and your own Powershell Core Product still gets delivered with this faulty module and I'm sure it breaks the usage for many people,, maybe without them even knowing. This is the Bugfix for the old module: https://github.com/PowerShell/PowerShellGetv2/pull/592 I'm adding this Bug here because I don't think you're looking at the bugs of your old module any more. I think fixing such a major bug with only one line should be doable if you're not able to get the new module out, I have to fix your module manually every time, that can't be it. Please do something about that :/ The fix is also very easy, it's just one line that needs to be fixed.

Expected behavior

Old module should reinstall Powershell Core modules in the global scope if they were originally installed in the global scope.

Actual behavior

Will reinstall ALL Powershell Core modules in the current user scope, even if they were originally installed in the global scope. This will only happen in Powershell Core.

Error details

No response

Environment data

Problem is in module PowerShellGetv2, doesn't depend on any other module.

Visuals

No response

echalone commented 2 years ago

Hi, is there any update or so? It's been over two years that this one-liner bug is in your product.