PrestaShop / prestashop-flashlight

A docker based testing utility for PrestaShop
MIT License
22 stars 8 forks source link

fix(build): target platform is no longer a build-arg #44

Closed jokesterfr closed 7 months ago

jokesterfr commented 7 months ago

A subtle issue was raised during the docker image publish operation, but was not catched by the CI checks.

This is because TARGET_PLATFORM was used as a combined string "linux/arm64,linux/amd64", and could not correctly be parsed in the Dockerfiles scripts.

To really solve this issue, I found more relevant to definitely rely on the OS than to provide error prone external variables : using arch command helps to figure out which arch is running during the Dockerfile build... Even in platform compatibility mode (target arch != build arch).