ON_INSTALL_MODULES_FAILURE does not detect all modules installation errors

sylardiere commented 7 months ago

The command: php -d memory_limit=-1 bin/console prestashop:module --no-interaction install "$module" returns an exit status of 0 even when the module wasn't installed.

/var/www/html/bin # php -d memory_limit=-1 ./console prestashop:module --no-interaction install facebookconversiontrackingplus-master-32014-187311.zip

  Cannot install module facebookconversiontrackingplus-master-32014-187311.zip. The module is invalid and cannot be loaded.  

/var/www/html/bin # echo $?
0

The setting ON_INSTALL_MODULES_FAILURE=fail is ignored in this scenario.

jokesterfr commented 7 months ago

The bug is probably in PrestaShop itself, but we can for sure find a workaround.

jokesterfr commented 6 months ago

@sylardiere seems this topic is now fixed right?

PrestaShop / prestashop-flashlight

ON_INSTALL_MODULES_FAILURE does not detect all modules installation errors #47