PrestaShop / prestashop-flashlight

A docker based testing utility for PrestaShop
MIT License
22 stars 8 forks source link

fix(chore): fixes #48 add a cross-compilation test #50

Closed jokesterfr closed 7 months ago

jokesterfr commented 7 months ago
Questions Answers
Description? Fixes https://github.com/PrestaShop/prestashop-flashlight/issues/48, there is a known issue on cross-compilation issue that was present since the introduction of the Node.js toolkit.

My previous attempt to port Node.js to Flashlight was overly complicated, and did not relied on the distributions (alpine or debian). That's a pitty because there're aimed precisely for resolving dependencies.

PrestaShop source code is not yet compatible to the latest 18.x and 20.x branches of Node.js. However we can change that.

Flashlight now ships also cross-compilation test to avoid such pain at release time in the future.


Note: recommended Node.js version set in the prestashop-versions.json file won't be resolved in the produced docker images. The core will be soon get a PR to support Node.js 16-20 on its front-end static assets.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Related to #48
How to test? Submit any PR, the CI will test it