search

Princeton-CDH / ppa-django

Princeton Prosody Archive v3.x - Python/Django web application
http://prosody.princeton.edu
Apache License 2.0
4 stars 2 forks source link

Fix for pairtree prefix issue #611

Closed laurejt closed 8 months ago

laurejt commented 8 months ago

Fixes #538 for HathiTrust imports via the admin interface but not bulk imports.

codecov[bot] commented 8 months ago

Codecov Report

Merging #611 (db6af24) into develop (b2f9f46) will not change coverage. Report is 10 commits behind head on develop. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #611 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 78 78 Branches 8 8 ========================================= Hits 78 78 ```
laurejt commented 8 months ago

@rlskoeser Thanks for the initial review. I've refactored the code so that more of the logic is within the class HathiObject itself. I also did some additional code clean-up to convert some cached properties into class attributes, but only for HathiObject.

laurejt commented 8 months ago

@rlskoeser Thanks for the follow-up review! This should be the last review request; I just refactored the tests to make a single initialization test for HathiObject.