search

Prinzhorn / scrollmeister

Open-source JavaScript framework to declaratively build scrolling experiences
https://www.scrollmeister.com/
MIT License
37 stars 5 forks source link

Error when schema contains reserved words #20

Open Prinzhorn opened 6 years ago

Prinzhorn commented 6 years ago

E.g. definining an attach prop would break the behavior

I think we can just collect all the properties at runtime

Prinzhorn commented 6 years ago

Also maybe prefix stuff like React? E.g. behaviorDidAttach?

Prinzhorn commented 6 years ago

Also maybe prefix stuff like React? E.g. behaviorDidAttach?

Might as well make all of them explicit, like appendBehaviorChild or behaviorDependencies or notifyBehaviors. In the long run this will avoid naming clashes. E.g. I can already see a behavior use a notify prop. However, throwing when your schema contains a notify prop would also achieve the desired result.