PrismarineJS / node-minecraft-protocol

Parse and serialize minecraft packets, plus authentication and encryption.
https://prismarinejs.github.io/node-minecraft-protocol/
BSD 3-Clause "New" or "Revised" License
1.23k stars 239 forks source link

1.19.1-1.19.3 #1037

Closed PandaUprising closed 1 year ago

PandaUprising commented 2 years ago

Support for 1.19.1-1.19.2

Any updates on this issue? no pressure or anything just wondering where your at with it!

Thank you, PandaUprising

extremeheat commented 2 years ago

Feel free to work on it, I don’t believe anyone is actively working on 1.19.1/2 so far.

PandaUprising commented 2 years ago

It would be interesting if another plugin E.g. ViaVersion could help with this or smth

PandaUprising commented 2 years ago

Feel free to work on it, I don’t believe anyone is actively working on 1.19.1/2 so far.

What would I do to add support for these versions?

extremeheat commented 2 years ago

Review the Minecraft Java code diff between 1.19 and 1.19.1 then implement them here

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files

https://github.com/extremeheat/extracted_mcauthlib/pull/1/files

Mainly chat changes

PandaUprising commented 2 years ago

Review the Minecraft Java code diff between 1.19 and 1.19.1 then implement them here

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files

https://github.com/extremeheat/extracted_mcauthlib/pull/1/files

Mainly chat changes

Ok cool, will have a look at that!

Edit: the second link doesn't exist

rom1504 commented 2 years ago

https://github.com/PrismarineJS/minecraft-data/issues/643

rom1504 commented 2 years ago

let's jump straight to 1.19.2 imo

rom1504 commented 2 years ago

https://wiki.vg/index.php?title=Protocol&action=history

rom1504 commented 2 years ago

https://github.com/extremeheat/extracted_minecraft_data/pull/1

rom1504 commented 2 years ago

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files#diff-cfc7f62190ac809b821fb45202a01f8de05f0c3081bd1e6350c6718f53b8692aR809

rom1504 commented 2 years ago

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files#diff-34a0b417dd277e6028b09a69130946df06fe14d800c4f80d6e09a32b030d78aeR12

rom1504 commented 2 years ago

lot of chat stuff changed

Shorent commented 1 year ago

I'm not super familiar with this project and would like to help, in your opinion what in node-minecraft-protocol most likely needs to change to fit the new minecraft protocol? Just wondering where I should look first.

I'd love to help get 1.19.2 mineflayer going

rom1504 commented 1 year ago

only https://github.com/PrismarineJS/minecraft-data/issues/643 copying protocol.json from 1.19 in 1.19.2 folder then making the right changes

Fruce commented 1 year ago

Support for 1.19.1-1.19.2

Any updates on this issue? no pressure or anything just wondering where your at with it!

Thank you, PandaUprising

YES! please please make it happen!!!!

Fruce commented 1 year ago

Need 1.19.1 and 1.19.2 support asap !

s-bauer commented 1 year ago

Need 1.19.1 and 1.19.2 support asap !

You're not in a position to demand anything. This is open-source. Implement it yourself or wait till someone else does the work for you - for free!

Kreyren commented 1 year ago

Need 1.19.1 and 1.19.2 support asap ! -- @Fruce (https://github.com/PrismarineJS/node-minecraft-protocol/issues/1037#issuecomment-1294575602)

If this is in a production environment then consider hiring a developer to fix it if you are not qualified to do that yourself or submit a bug bounty through e.g. https://issuehunt.io or https://github.com/sponsors/PrismarineJS.

In terms of the amount of bug bountry consider minimal wage per hour and the amount of development hours it will take to solve the issue.

You're not in a position to demand anything. This is open-source -- @s-bauer (https://github.com/PrismarineJS/node-minecraft-protocol/issues/1037#issuecomment-1305858521)

You sound like an annoying child when you make this painfully incompetent excuse, shush and be responsible for the code you write.

BasToTheMax commented 1 year ago

How can we implement 1.19(.2)? What changes need to be made?

rom1504 commented 1 year ago

See the open PR on the topic. The chat need to be changed.

Feel free to discuss at #contribute in discord

On Sun, Nov 13, 2022, 10:03 Bas @.***> wrote:

How can we implement 1.19(.2)? What changes need to be made?

— Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/node-minecraft-protocol/issues/1037#issuecomment-1312678496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437SSDQQUBWEL7PWRSBLWICVGBANCNFSM6AAAAAAQFKPV5E . You are receiving this because you commented.Message ID: @.***>

rom1504 commented 1 year ago

https://github.com/PrismarineJS/node-minecraft-protocol/issues/1046 next step is this

PandaUprising commented 1 year ago

And now comes 1.19.3...

TinyDerp commented 1 year ago

Is 1.19.2 available? And is there any progress on 1.19.3? Just asking.

rom1504 commented 1 year ago

blocked by https://github.com/PrismarineJS/node-minecraft-protocol/issues/1046 ; please read

DanielRamosAcosta commented 1 year ago

Now that #1046 has been merged, what would be the next steps? Anything that we could help @rom1504?

sebasdt commented 1 year ago

hey, What is the progress on 1.19.3? I saw in the latest update 1.19.3 is supported, is this correct?

rom1504 commented 1 year ago

It's done

Mineflayer PR still open