search

PrismarineJS / node-minecraft-protocol

Parse and serialize minecraft packets, plus authentication and encryption.
https://prismarinejs.github.io/node-minecraft-protocol/
BSD 3-Clause "New" or "Revised" License
1.2k stars 241 forks source link

UnsignedContent correction for playerChat event. #1263

Closed Ynfuien closed 6 months ago

Ynfuien commented 7 months ago

When emitting one of playerChat events, there was used nonexisting packet.unsignedContent, to set unsignedContent field. So when using playerChat event, unsignedContent was unknown.

frej4189 commented 7 months ago

The field is called unsignedContent - at the very least it is in 1.19.2

https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.19.2/protocol.json#L3319

If other versions have a different field name you should fix that in minecraft-data instead

rom1504 commented 6 months ago

@frej4189 I read unsignedChatContent where you are pointing. What am I missing?

rom1504 commented 6 months ago

ah this PR https://github.com/PrismarineJS/minecraft-data/pull/795/files