search

PrismarineJS / node-minecraft-protocol

Parse and serialize minecraft packets, plus authentication and encryption.
https://prismarinejs.github.io/node-minecraft-protocol/
BSD 3-Clause "New" or "Revised" License
1.2k stars 241 forks source link

Acknowledge returning to configuration state if in play state. #1284

Closed wgaylord closed 5 months ago

wgaylord commented 5 months ago

node-minecraft-protocol fix for part of https://github.com/PrismarineJS/mineflayer/issues/3292

Seems we missed this detail of the configuration protocol since the server never normally transitions back into the config state.

extremeheat commented 5 months ago

Where does configuation_acknowledged come from?

wgaylord commented 5 months ago

It comes from wiki.vg and the MC source, its also a play state packet. Also detailed here https://github.com/extremeheat/extracted_minecraft_data/blob/client1.20.2/client/net/minecraft/client/multiplayer/ClientPacketListener.java#L735-L757

extremeheat commented 5 months ago

It's not in protocol.json, this will throw

wgaylord commented 5 months ago

It's not in protocol.json, this will throw

It is in the protocol.json

extremeheat commented 5 months ago

I see, it's in 1.20.2 but not 1.20.3

wgaylord commented 5 months ago

I see, it's in 1.20.2 but not 1.20.3

Ah seems to be another case of a spelling mistake in 1.20.2 protocol.json

wgaylord commented 5 months ago

Now have https://github.com/PrismarineJS/minecraft-data/pull/841 open to fix that mistake.

wgaylord commented 5 months ago

Could we look into getting this merged, have had multiple people in the discord getting tripped up the the bug it fixes on multiplayer servers that use hubs.

extremeheat commented 5 months ago

/makerelease 1.45.1