ProNooberEX / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
0 stars 0 forks source link

Conversation on the Missions #1

Closed TheGiraffe3 closed 4 months ago

TheGiraffe3 commented 5 months ago

Start the issue

ProNooberEX commented 5 months ago

Ok

ProNooberEX commented 5 months ago
截屏2024-06-14 21 33 08

I think you gave the same outfits to the Scan fleet that the Raiding Fleet uses While only the Scan Fleet obtaines the Quarg equipments as they are the ones boarding the Quarg ships

TheGiraffe3 commented 5 months ago

You’re right. Do you want to try changing that or should I?

ProNooberEX commented 5 months ago

You’re right. Do you want to try changing that or should I?

I will do it myself, no worries, do you know which file the outiftter code lay in?

TheGiraffe3 commented 5 months ago

At the bottom of your pull request where it says checks, some of them are failing. If you want to fix those, it would be helpful.

TheGiraffe3 commented 5 months ago

sales.txt in the human folder.

ProNooberEX commented 5 months ago

At the bottom of your pull request where it says checks, some of them are failing. If you want to fix those, it would be helpful.

截屏2024-06-14 21 51 40

How do I view the checks themsleves?

ProNooberEX commented 5 months ago

Warning: fleet "Quarg Hunters" is referred to, but not fully defined. Warning: fleet "Quarg Jumpers" is referred to, but not fully defined. Warning: fleet "Quarg Planetary Defense" is referred to, but not fully defined. Warning: outfit "Javalin Turret" is referred to, but not fully defined. Warning: outfit "Modified Blaster Turrent" is referred to, but not fully defined. Warning: phrase "Quarg" is referred to, but not fully defined. Parse completed with at least one error(s). Didn't we define them in the txt files?

ProNooberEX commented 5 months ago
截屏2024-06-14 22 06 05

Warning: fleet "Quarg Hunters" is referred to, but not fully defined. Warning: fleet "Quarg Jumpers" is referred to, but not fully defined. Warning: fleet "Quarg Planetary Defense" is referred to, but not fully defined. Warning: outfit "Javalin Turret" is referred to, but not fully defined. Warning: outfit "Modified Blaster Turrent" is referred to, but not fully defined. Warning: phrase "Quarg" is referred to, but not fully defined. Parse completed with at least one error(s). Didn't we define them in the txt files?

TheGiraffe3 commented 5 months ago

I have had problems with that too. The Quarg fleets may be trouble, but the things that are in the base game don’t need to be changed.

ProNooberEX commented 5 months ago
截屏2024-06-16 20 39 29

I'm curious on what are the remnant new missions for, may you explain it to me?(Also I thought we are suppose ot get permission from Zitchas before adding Remnant branches?)

TheGiraffe3 commented 5 months ago

I wasn’t aware I added that. But it’s okay, because that was changed in the main game. I updated your branch to be the same as the base game’s branch, so it will be the same as in the old repository.

TheGiraffe3 commented 5 months ago

If you click on the Files Changed tab, it won’t show that it got changed, because the master branch has that.

ProNooberEX commented 5 months ago

I know that in game tghere are two types of makrs, one with a bright light blue dot signalling go to there to complete missions and the other darker and says that one must jump to the systems without the need to land, how do I know which is the "mark" variable controlling?

TheGiraffe3 commented 5 months ago

The bright one is a mission, the dark one is a waypoint. Mark is basically a new version of waypoint without the need to visit it. Mark is the dark blue, I think.

TheGiraffe3 commented 4 months ago

@ProNooberEX any objections to me putting my mission in master?

TheGiraffe3 commented 4 months ago

@ProNooberEX it looks like I've got both of our pull requests to no longer have problems! Please review mine, #10.

ProNooberEX commented 4 months ago

Ok I will

TheGiraffe3 commented 4 months ago

Should I just squash it in now?

ProNooberEX commented 4 months ago

Go ahead, I've viewed the pirate 0 mission and its ok

Should I just squash it in now?

TheGiraffe3 commented 4 months ago

Didn't tell me you'd reviewed it, but okay.

TheGiraffe3 commented 4 months ago

Done.

TheGiraffe3 commented 4 months ago

How about we open a new conversation issue?

ProNooberEX commented 4 months ago

How about we open a new conversation issue?

I think yes, because we both completed at least pirate mission 0 right?

TheGiraffe3 commented 4 months ago

Right.

ProNooberEX commented 4 months ago

Right.

Then I suppose go ahead

TheGiraffe3 commented 4 months ago

See #11.