ProNooberEX / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
0 stars 0 forks source link

Conversation on the Missions #1

Closed TheGiraffe3 closed 3 months ago

TheGiraffe3 commented 3 months ago

Start the issue

ProNooberEX commented 3 months ago

(the Quarg fleets should go in the Quarg file)

Is it ok for me to call a quarg fleet when the txt file defining the quarg fleet is in the quarg file instead of the human file?

TheGiraffe3 commented 3 months ago

Yes.

ProNooberEX commented 3 months ago

Well, GitHub doesn’t know what we’re doing. Those are checks the people in the main game wrote, but I think they may have dependencies not in this repository-aka we don’t have the information those tests need to pass, but it should work anyway. That’s guessing, but we can probably ignore them for now.

Btw so the people in the main endless sky repository could see what we are doing?

TheGiraffe3 commented 3 months ago

They can see what we’re doing if they manually go here, but the actions I don’t think they can see.

ProNooberEX commented 3 months ago

They can see what we’re doing if they manually go here, but the actions I don’t think they can see.

Ok thats good, I am just fearing they would get mad as us?(They probably would have wanted Zitchas' consent on updating the files)

TheGiraffe3 commented 3 months ago

They want Zitchas’ permission for the Remnant stuff. But we’re not modifying that. And they can’t get mad at us, it’s a free project. They can not put it in, but they can’t get angry.

ProNooberEX commented 3 months ago

They want Zitchas’ permission for the Remnant stuff. But we’re not modifying that. And they can’t get mad at us, it’s a free project. They can not put it in, but they can’t get angry.

Ok that is good news, and btw why do you say it doesn't matter until we PR it?

TheGiraffe3 commented 3 months ago

Because it’s not ready. Right now we don’t want it in the base game, and it’s okay if it fails some checks. Once it’s ready, it needs to pass the checks.

ProNooberEX commented 3 months ago

Because it’s not ready. Right now we don’t want it in the base game, and it’s okay if it fails some checks. Once it’s ready, it needs to pass the checks.

Wait...we are ACTUALLY adding this to the game? WOW!

TheGiraffe3 commented 3 months ago

Eventually, we’re hoping to. Right now, no, but (hopefully) eventually.

ProNooberEX commented 3 months ago

Man this is a lifetime's opportunity...I never thought I would be actually leaving an imprint on the game I have been playing for 3 years.

TheGiraffe3 commented 3 months ago

Well, they may not accept it. But I’ve been playing this for 5 months and have already contributed.

And this is a lot bigger than any of my stuff.

ProNooberEX commented 3 months ago

Well, they may not accept it. But I’ve been playing this for 5 months and have already contributed.

What did you add may I ask?

TheGiraffe3 commented 3 months ago

Typo fixes. 😄

ProNooberEX commented 3 months ago

You think that, if our contribution is accepted...maybe Zitchas would give us Person Ships and ingrain our mark on the game for others to see?

TheGiraffe3 commented 3 months ago

I’m not sure we need person ships. Also, those are for bigger contributions, such as new aliens. We only have a storyline… but we will be added to the contributors list.

TheGiraffe3 commented 3 months ago

But you can make a plugin that adds a person ship for yourself.

ProNooberEX commented 3 months ago

Anyways this would be something for potentially thousands of players to see...which is truly a remarkable experience.

TheGiraffe3 commented 3 months ago

It is. Of course, not many people will be pirates on their first playthrough, but any contributions are nice.

ProNooberEX commented 3 months ago

Btw why does Github has this protection thing

You probably set it up somehow.

Also I want to ask if we were to debug this how do we do it? Do we download and play out the plot of this edited version of the game or something out?

We copy the contents of the files we changed and put them in our data files. I only know the path in Mac, but you right-click (two fingers if you’re on the built-in touchpad) and then Show Package Contents. Then you go through the Contents folder into Resources/data/human, and put the pirate file in there. If this doesn’t make sense, say so, I may be able to clarify it more.

Also Didn't this pose the risk of messing up your file you are currently playing?

It does, so you’ll probably want to start a new game with the World Forge plugin. It’s a way to test content without messing up saves. Basically you start on a planet called Forge which has all outfits and ships available for sale.

Btw here you said a World Forge Plugin, where and how could we add plugin to our game?(My game is on steam btw)

TheGiraffe3 commented 3 months ago

You can post a plugin anywhere. World Forge is here.

TheGiraffe3 commented 3 months ago

But to add a plugin, we just put it in the plugins folder ([your username]/Library/Application Support/endless-sky/plugins)

The saves folder is a level up.

ProNooberEX commented 3 months ago

Btw I finished the beginning Mission for the pirate 0 beginning file, if you want you can check it out.

So we probably don’t need the Quarg ships redefined, they’ll work anyway. Also, the outfits means they are carrying them, not using them.

Here you said the outfits are for carrying purposes, then how do I mount them onto the fleets I desire?

TheGiraffe3 commented 3 months ago

You want to put them on the ships?

TheGiraffe3 commented 3 months ago

You have to make variants, and add them to the fleets.

ProNooberEX commented 3 months ago

You have to make variants, and add them to the fleets.

Understood

ProNooberEX commented 3 months ago

Btw do any other contributes wish to join us?

TheGiraffe3 commented 3 months ago

I don’t know. You can ask if you want, but not everyone will like your writing style, and may want to change it.

ProNooberEX commented 3 months ago

I don’t know. You can ask if you want, but not everyone will like your writing style, and may want to change it.

Is my writing style too bland?

TheGiraffe3 commented 3 months ago

Well, you write in past tense. And grammar-wise, there might be problems? I don’t have problems with it, but I’m not a great writer…

ProNooberEX commented 3 months ago

Yeah true...maybe that is the case.

ProNooberEX commented 3 months ago

Here it says that the personalities of the pirates are "heroic", is this fitting for their character?

截屏2024-06-14 09 14 04
TheGiraffe3 commented 3 months ago

Here it says that the personalities of the pirates are "heroic", is this fitting for their character?

截屏2024-06-14 09 14 04

Yes, because they’re not afraid of people. They want to attack and destroy (see this for more details).

ProNooberEX commented 3 months ago

What does the appeasing flag do?(I can't find it in the page)

TheGiraffe3 commented 3 months ago

It means that if a ship’s shields and hull drop low enough, it will dump its cargo. (so that the pirates pick it up and then don’t destroy the ship)

ProNooberEX commented 3 months ago

Should I set the Scanned fleets quarg skylance to quarg anti missle?(I think that the pirate lord would only have the ability to board two to three quarg ships, so a fleet of them would be unlikely)

TheGiraffe3 commented 3 months ago

The outfits part doesn’t mean they are installed. It actually doesn’t work at all, outfitters is required.

In response to your question, both would probably be fine, because the Quarg have both.

TheGiraffe3 commented 3 months ago

Shall I make the outfitter?

ProNooberEX commented 3 months ago

Shall I make the outfitter?

Go ahead

TheGiraffe3 commented 3 months ago

Shall I make the outfitter?

Go ahead

Done.

You are aware that these ships won’t have them equipped though?

ProNooberEX commented 3 months ago

Shall I make the outfitter?

Go ahead

Done.

You are aware that these ships won’t have them equipped though?

Can you make them equip these?

TheGiraffe3 commented 3 months ago

Sure, though it will take a while.

ProNooberEX commented 3 months ago

Oh um, on a side note, I may be taking screenshots of potentially txt writing edited by you for providing evidence for thius activity for application purposes, May you permit me potentially exposing your code to outside officials?(If this troubles you I will just screenshot code written by myself)

TheGiraffe3 commented 3 months ago

Seeing as how it’s not private anyway-everyone can see it-and it’s not important data, it’s fine.

No problem.

ProNooberEX commented 3 months ago

Seeing as how it’s not private anyway-everyone can see it-and it’s not important data, it’s fine.

No problem.

Thank you so much!

ProNooberEX commented 3 months ago

Did you move the "Quarg Jumpers" and "Quarg Hunters" to the quarg.txt?

TheGiraffe3 commented 3 months ago

Did you move the "Quarg Jumpers" and "Quarg Hunters" to the quarg.txt?

Yes. You can still use them in other places.

TheGiraffe3 commented 3 months ago

Made variants and added them to fleets.

At 200 comments, let’s move the discussion to another issue.

ProNooberEX commented 3 months ago

I agree, after the addition of the variants to fleets I think we are almost done with the pirate 0 txt(at least in my piratemission branch).

TheGiraffe3 commented 3 months ago

In your branch, yes. In mine? Not really…