search

Professor-Redwood-Team / Professor-Redwood

Pokemon Go Discord Bot
MIT License
34 stars 21 forks source link

Added Gen 4 Support #79

Closed ZVelasco closed 6 years ago

ZVelasco commented 6 years ago

Credit to Ilúvatar on Discord from Eureka,CA

kc135576 commented 6 years ago

I think we can merge these in for now, but there's no fast/charge moves. @mralanlee ?

Alterraia commented 6 years ago

Pokemon Go Hub doesn't have any of the fast/charge moves listed. But your current version of pokemon.json also didn't have the moves for gen 3, which I added, unless I just never updated.

I also corrected the pokemon numbers so that each pokemon has their dex # instead of being off by 1.

In addition to this, in case a zero was required, I added MissingNo as the 0 placeholder.

I'm currently updating pokemon.json with the new stats for all of the pokemon, as well as cp.json, which I'll send over to ZValasco when I'm done. Takes a while, but it will be done.

Alterraia commented 6 years ago

Oh btw, the update also includes alolan forms. Not certain if you wanted to include them, but they are there, making it possible for the bot to recognize alolan_exeggutor or alolan_marowak.

mralanlee commented 6 years ago

This will need to be refactored significantly in the future. Too many items inside the array and it'll be a burden on memory usage.

Alterraia commented 6 years ago

Well, something will have to be addressed soon, because we're only barely on Gen 4 and there's still 3 other Gens plus the one from 2019.