ProjectKig / KigPaper

Paper 1.8.8 fork with critical performance tweaks, bug fixes and gameplay improvements.
https://playkig.com
38 stars 11 forks source link

Citizens Breaks (NoSuchMethodError for getEntityMetadata) #10

Open xcodian opened 2 years ago

xcodian commented 2 years ago

Hello, I'm running into a bit of an incompatibility issue here...

I compiled this for myself, and ran a test server with it.

Upon trying to use Citizens2, there is a method lookup error.

java.lang.NoSuchMethodError: org.bukkit.craftbukkit.v1_8_R3.CraftServer.getEntityMetadata()Lorg/bukkit/craftbukkit/v1_8_R3/metadata/EntityMetadataStore;

This error cannot be reproduced on a regular Paper installation, so I am wondering whether there is a breaking change to the org.bukkit.craftbukkit.v1_8_R3.CraftServer.getEntityMetadata() method?

Is there a way to fix this, or some patch I should exclude when building?

Thank you for any support!

Java Version

openjdk version "1.8.0_312"
OpenJDK Runtime Environment (build 1.8.0_312-b10)
OpenJDK 64-Bit Server VM (build 25.312-b10, mixed mode)
archer-321 commented 2 years ago

I can reproduce the error with the latest Citizens CI build. It seems like a1e47874 broke this feature as it removed the method Citizens is trying to access.

I know it's possible to patch Citizens to work with our updated API, but sadly, I don't have the time to look into this problem myself in the next couple of days.