common.php does not have a proper php header

[Prophidys]

From tical....@gmail.com on February 09, 2011 10:17:19

What steps will reproduce the problem? 1. Access rtg.php via the web 2. 3. What is the expected output? What do you see instead? Throws a MySQL connection error because common.php does not have a proper php header like '<?php' but stead has simply '<?'. What version of the product are you using? On what operating system? rtg2 pulled 2/9/2011, running on FC14 x64.

Not sure if this is perhaps a PHP bug, maybe it's normal to include files in PHP with simply '<?'.

Original issue: http://code.google.com/p/rtg2/issues/detail?id=19

[Prophidys]

From terry.ro...@gmail.com on February 09, 2011 12:44:37

Seems like your php installation does not have short tags enabled. These allow you to use <? instead of <?php.

More information: http://www.bin-co.com/php/articles/using_php_short_tags.php You'll want to modify your php config or replace '<?' with '<?php' in rtg.php.

[Prophidys]

From tical....@gmail.com on February 09, 2011 12:59:12

Thanks, it would appear you're correct, as my other CentOS boxes run regular RTG just fine "out of the box", that is, without a modified common.php (and they apparently have short tags enabled). I've never observed the <? in the wild before. Perhaps, in an effort to become more universal and in the overall spirit of this project, a patch for <?php is warranted? I'll let the committers quarrel over that.

[Prophidys]

From ced.leco...@gmail.com on January 27, 2012 14:24:55

You're right we can't use the short tag because some distributions doesn't active the short tag by default and this file can create a security hole.

The problem is fixes in rev 24.

Status: Fixed