search

Public-Health-Scotland / SBSS

Reproducible Analytical Pipeline of the Scottish Bowel Screening Programme Statistics (SBSS) publication
1 stars 0 forks source link

Tom script 5 #10

Closed gavinc01 closed 5 years ago

gavinc01 commented 5 years ago

A team effort on this one. Matches the outputs from SPSS, with the exception of the uptake_history variable which is slightly different. I'll have to go back and look at in script 1 once the various other approvals and merges have been completed.

jackhannah95 commented 5 years ago

Great work guys, this is more or less ready to be approved. The comments are mostly just to help me understand what's going on.

Stuff like using case_when instead of a nested ifelse and adding more commentary to the confidence intervals aren't urgent and should be left for sometime in the future. I've only mentioned them now so I can create an issue and reference this PR.

gavinc01 commented 5 years ago

@jackhannah95 I've updated to fix a couple of those, the rest will have to be an issue as you say, assuming you're happy with what's been done