Public-Health-Scotland / SBSS

Reproducible Analytical Pipeline of the Scottish Bowel Screening Programme Statistics (SBSS) publication
1 stars 0 forks source link

Markdown summary #9

Closed gavinc01 closed 5 years ago

gavinc01 commented 5 years ago

I think this is as good as it's going to get for the moment. A few minor issues to possibly work through but it does the job.

gavinc01 commented 5 years ago

Hi Jack, apologies, I should have updated this sooner. The outstanding updates at the moment are:

<Div custom-style = "centre_justified"></div>. (it took me a good 10 minutes to figure out/remember how to display that as code)

This was successful in centre-justifying the chart, however it all fit on 2 pages when it was left-justified, now I'm finding I have to shrink the chart by quite a lot to get it to fit on 2 pages.

The other issue was the ordering of the legend should probably be Uptake first then Standard rather than the order it is in at the moment. This is obviously very minor, but seems like something that it should be possible to fix, and some googling reveals people who have solved the problem, but the things I tried didn't work unfortunately.

If you've got time to help with these that would be great, if not no worries - there are simple manual workarounds for both issues, Also I'm in Meridian today if you want to speak about it further. Will look at the other stuff today/tomorrow.

gavinc01 commented 5 years ago

Didn't comment with your githandle there @jackhannah95 !

jackhannah95 commented 5 years ago

Hi @gavinc01,

Hopefully those two commits have fixed the issues with the legend. I was working off two different versions of the chart so hopefully I've included all (or most) of the theme arguments you wanted. Can I ask that you don't make any changes directly to this branch for the time being? I'll be at Gyle Monday - Wednesday next week so plenty of opportunity to talk about any changes needed.

Not figured out how to centre the chart yet, but I'm working on it.