Restructure the officers table

[rnair-tw]

User Story

As a user who wants keep my data in the system accurate and up to date I want to be able to see fields I understand in my data table So that I am clear about my data in the system

Definition of Done

The following tasks have been completed:

• [x] Rename the windows_username column in the officers table to employee_id and make this column into a required part of the primary key.
• [x] Replace all references to windows_username in the codebase with employee_id (Note: also search and replace windowsUsername with employeeId)
• [x] Drop the officer_number column in the officers table & remove any code references to it. Officer number is now a useless & misleading field.
• [x] Rename the supervisor_officer_number column in officers table to supervisor_employee_id and reroute code references to the field to the new name. (note: also search for supervisorOfficerNumber and replace with supervisorEmployeeId) (restrict changes to Officers Table, not Cases_Officers)
• [x] Update the columns for the officers seeders to reflect newly missing column and name changes after migration so that you can compose up again. Ensure all rows of dummy data have unique employeeIds. (You may need to delete the dummy supervisor_emplee_ids)

Acceptance Criteria

Given I am in the database in all environments When I check the fields Then there's no mention of windows_username in the codebase or in any database, instead, we use employee_id. And employee_id is a unique required field which is part of the primary key And there is no longer and mention of officer_number in the officers table.

Given I am on any non prod client environment When I search for officers Then I am able to search for dummy data officers

[espinolaJ-TW]

NOTE:

Test in csvCaseExport.test.js from line 602 to 604 were commented out because of adjustments needed for when cases_officer table is restructured .

expect( officerComplainantRow["Officer Complainant Windows Username"] ).toEqual(${caseOfficerComplainant.windowsUsername});

[thoughtworks-vwong]

Regression testing complete of New Orleans and everything looks good: https://docs.google.com/spreadsheets/d/1IKheyqBWUn5NbPqIsQT9Q_5ezHH72nwCKDyVS_rGCv4/edit#gid=630305465