Purgeable / full-app

Keep all functionality for (parsers + db + frontend API) inside one Django project.
0 stars 1 forks source link

question: why python 2.7? #27

Closed Rub4ek closed 7 years ago

Rub4ek commented 7 years ago

I saw there is python 2.7 defined in travis config: https://github.com/mini-kep/full-app/blob/master/.travis.yml#L3

Why not 3.5 or even 3.6. The future is here :) Parser works with 3.6 for example: https://github.com/mini-kep/parser-rosstat-kep/blob/master/.travis.yml#L3

epogrebnyak commented 7 years ago

I fully agree we just need 3.6

26 сент. 2017 г. 14:08 пользователь "Alexey Kuznetsov" < notifications@github.com> написал:

I saw there is python 2.7 defined in travis config: https://github.com/mini-kep/full-app/blob/master/.travis.yml#L3

Why not 3.5 or even 3.6. The future is here :) Parser works with 3.6 for example: https://github.com/mini-kep/parser-rosstat-kep/blob/master/.travis.yml#L3

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mini-kep/full-app/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AI1grqObyqeODXxff6vSXsNNL69Q4DcOks5smNsWgaJpZM4PkEic .

tinivir commented 7 years ago

@Rub4ek in Travis config defined a project version of Python. The project is on 2.7 Python. 2.7 is stable fully version. What features of 3.6 Python do you use in parser, or we plan to use in full-app?

epogrebnyak commented 7 years ago

Everyone, we have to migrate to 3.6, no 2.7.

26 сент. 2017 г. 15:30 пользователь "tinivir" notifications@github.com написал:

@Rub4ek https://github.com/rub4ek in Travis config defined a project version of Python. The project is on 2.7 Python. 2.7 is stable fully version. What features of 3.6 Python do you use in parser, or we plan to use in full-app?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mini-kep/full-app/issues/27#issuecomment-332182882, or mute the thread https://github.com/notifications/unsubscribe-auth/AI1gripQ_-AAnss2vBrl9QjqbjubQ1ycks5smO59gaJpZM4PkEic .

Rub4ek commented 7 years ago

@tinivir it works fine at least on 3.5, cuz I use 3.5 for it. I, to be honest, find out that it was developed on 2.7 only today =)

epogrebnyak commented 7 years ago

It appears as very stable version, capable to run on 3,* indeed, but we have to move to 3.6.

Rub4ek commented 7 years ago

@epogrebnyak, I just checked packages that are used in the project:

Django 1.11 Python: 2.7, 3.4, 3.5, 3.6

djangorestframework 3.x Python: 2.7, 3.2, 3.3, 3.4, 3.5, 3.6

django-filter Python: 2.7, 3.3, 3.4, 3.5

pytz Python: 2.4 or higher

So not sure about django-filter. Maybe just not up to date docs. Need to check

tinivir commented 7 years ago

I've already update to 3.6 https://github.com/mini-kep/full-app/commit/5d3ca418bb109557ee2a3b179f8fc5a77ced6ea4