QAZIMAAZARSHAD / Income-Tax-Calculator

Income Tax Calculation System For A Salaried Person
https://github.com/QAZIMAAZARSHAD/Income-Tax-Calcultor/blob/main/README.md
MIT License
36 stars 57 forks source link

corrected another bug with sharing #129

Closed akash-rajak closed 3 years ago

akash-rajak commented 3 years ago

Issue Number

fixes #126

Describe the changes you've made

here i have separated both , showing details pop up window, and the sharing permission asking window.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist

akash-rajak commented 3 years ago

@QAZIMAAZARSHAD , can you please check this one, i have updated

QAZIMAAZARSHAD commented 3 years ago

Same result again

akash-rajak commented 3 years ago

can you please do one thing, if possible please share the link of code, so that running that code i can get idea of some error, because its running fine in mine so not am no getting crashing error

QAZIMAAZARSHAD commented 3 years ago

can you please do one thing, if possible please share the link of code, so that running that code i can get idea of some error

How can I share a link?

I am just pushing changes of the PR to the project copy.

akash-rajak commented 3 years ago

you will be running the python code, if possible pls send me that code in slack in direct message

QAZIMAAZARSHAD commented 3 years ago

https://drive.google.com/drive/folders/1fv8XZNXGiZJKTmpFohbOrJDVowbE5_m1?usp=sharing

Final Projectcopy.py is application after your changes.

akash-rajak commented 3 years ago

Can you please tell me that code crashes at which part or it is not running from splash screen only. Or on giving any input it crashes. As it is running on mine.

QAZIMAAZARSHAD commented 3 years ago

Can you please tell me that code crashes at which part or it is not runs from from splash screen only. Or on giving any input it crashes. As it is running on mine.

It crashes as soon as the application opens.

From the start, it closes even before the splash screen opens.

akash-rajak commented 3 years ago

In Final Projectcopy.py, line 492 containing this code, mbox.showinfo("User's tax info ",f"Name: {myname.get()} \n\n Income Tax calculation is: \n\n Oldtax: {old} Newtax: {new} Taxsave: {tax_save}")

this line is not indented perfectly, there is a extra single space before mbox so i think clearing that one space before will work

QAZIMAAZARSHAD commented 3 years ago

Already checked.

Indentation is fine.