search

QAZIMAAZARSHAD / Income-Tax-Calculator

Income Tax Calculation System For A Salaried Person
https://github.com/QAZIMAAZARSHAD/Income-Tax-Calcultor/blob/main/README.md
MIT License
36 stars 57 forks source link

Update pull_request_template.md #155

Closed manasb15 closed 3 years ago

manasb15 commented 3 years ago

This point in the checklist :

(I have added my name in the contributors list at the end of README.md file.)

is obsolete. So it is wise to remove it.

@QAZIMAAZARSHAD please assign this to me under DCP21

QAZIMAAZARSHAD commented 3 years ago

Yesterday you said it helps you in remembering git commands.

I want to tell, you can do these changes without using git quickly. Just open the pull request template file in your repo, remove the line, commit changes, make PR. And its done.

manasb15 commented 3 years ago

@QAZIMAAZARSHAD Yes I know that method as well but I heard that it was like a shortcut or bad practice.

QAZIMAAZARSHAD commented 3 years ago

@QAZIMAAZARSHAD Yes I know that method as well but I heard that it was like a shortcut or bad practice.

Yaa in the case of many changes it causes difficulty in merging and few other problems like unnecessary indentations etc.

manasb15 commented 3 years ago

@QAZIMAAZARSHAD Ok then i will update it online for these small changes