search

QAZIMAAZARSHAD / Income-Tax-Calculator

Income Tax Calculation System For A Salaried Person
https://github.com/QAZIMAAZARSHAD/Income-Tax-Calcultor/blob/main/README.md
MIT License
36 stars 57 forks source link

Make the size of window fixed so that full content is visible. #19

Closed techabhi08 closed 3 years ago

techabhi08 commented 3 years ago

If the user is resizing the window the content is disappearing. This can be fixed so that the screen size remains the same.

Screenshot (410) Screenshot (411)

techabhi08 commented 3 years ago

@QAZIMAAZARSHAD please assign me this new issue that I have created or should I directly submit the result?

QAZIMAAZARSHAD commented 3 years ago

@QAZIMAAZARSHAD please assign me this new issue that I have created or should I directly submit the result?

Go ahead @techabhi08.

I'll assign you this soon.

techabhi08 commented 3 years ago

Thank you

techabhi08 commented 3 years ago

@QAZIMAAZARSHAD I have solved this issue but whatever changes I am making to my github file and contributing it, it is committing changes in another issue and no pull request is being created for this one. How should I resolve this?

QAZIMAAZARSHAD commented 3 years ago

This should not happen.

Wait till I merge your previous PR, delete the latest commit in your PR you have done for this issue.

Once I merge that PR then generate a new PR by making changes for this issue, I hope that will solve the issue.

techabhi08 commented 3 years ago

ok doing the same.

On Wed, 9 Jun 2021 at 21:09, Qazi Maaz Arshad @.***> wrote:

This should not happen.

Wait till I merge your previous PR, delete the latest commit in your PR you have done for this issue.

Once I merge that PR then generate a new PR by making changes for this issue, I hope that will solve the issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/QAZIMAAZARSHAD/Income-Tax-Calcultor/issues/19#issuecomment-857810880, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASCSF4PCB67ETLEIDARPTKDTR6DMBANCNFSM46MHPVGQ .

techabhi08 commented 3 years ago

I have done the change can you please confirm. Also is that issue number #10 resolved by my PR?

QAZIMAAZARSHAD commented 3 years ago

I have done the change can you please confirm. Also, is that issue number #10 resolved by my PR?

No issue 10 is not resolved by your PR. Improve your code before anyone else sends a better solution.

techabhi08 commented 3 years ago

@QAZIMAAZARSHAD have you merged the PR can i create a new one now?

QAZIMAAZARSHAD commented 3 years ago

@QAZIMAAZARSHAD have you merged the PR can I create a new one now?

No LGM-Soc will start from 10 June. Also, your PR for the wrong result issue is not solving the issue so you can close that.

Your changes for this issue #19 are perfectly fine you can make PR for this one.

techabhi08 commented 3 years ago

@QAZIMAAZARSHAD did you find the solution useful like is this issue resolved?

QAZIMAAZARSHAD commented 3 years ago

Yes, I will merge your PR tomorrow morning.

techabhi08 commented 3 years ago

OK Thanks a lot.